[T2135] FIX: Security issue in project - Check domain of presentation video link. #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecino
requested changes
Feb 4, 2025
ecino
reviewed
Feb 10, 2025
| parsed_url = urlparse(self.presentation_video) | ||
| domain = parsed_url.netloc.lower() | ||
|
|
||
| if not (domain == "youtube.com" or domain.endswith(".youtube.com") |
There was a problem hiding this comment.
Isn't the second test including the first condition. Wouldn't this give the same result (and simplify the code)?
Suggested change
| if not (domain == "youtube.com" or domain.endswith(".youtube.com") | |
| if not (domain.endswith("youtube.com") |
| domain = parsed_url.netloc.lower() | ||
|
|
||
| if not (domain == "youtube.com" or domain.endswith(".youtube.com") | ||
| or domain == "vimeo.com" or domain.endswith(".vimeo.com")): |
There was a problem hiding this comment.
Suggested change
| or domain == "vimeo.com" or domain.endswith(".vimeo.com")): | |
| or domain.endswith("vimeo.com")): |
There was a problem hiding this comment.
I don't think so, because it would mean that www.avimeo.com/video1 would pass, which is exactly what we want to avoid.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.